Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MSRV issues by re-releasing sha1, sha2, sha3, md5, and whirlpool #399

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

newpavlov
Copy link
Member

@newpavlov newpavlov commented Sep 2, 2022

Closes #394
Closes #395
Closes #396
Closes #397
Closes #398

@striezel
Copy link
Contributor

striezel commented Sep 2, 2022

As mentioned in the linked issues: Thanks for the attempted fix here. 👍

Unfortunately, none of the issues was fixed in this pull request / by the new releases. The new releases still contain a resolver = "2" line in their generated Cargo.tomls:

I've adjusted the title of each correponding issue to reflect that the newer versions are affected, too.

@newpavlov
Copy link
Member Author

Weird... I specifically used the latest stable toolchain (1.63) to do the publishing.

@newpavlov
Copy link
Member Author

I guess resolver = "2" has leaked from the workspace Cargo.toml. I will temporarily remove it and will do re-releases again.

cc @tarcieri

@striezel
Copy link
Contributor

striezel commented Sep 2, 2022

I guess resolver = "2" has leaked from the workspace Cargo.toml. I will temporarily remove it and will do re-releases again.

Maybe.

Just for reference: resolver = "2" was added to the workspace Cargo.toml in dfcfb21 / PR #375

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants